add notes about what the job states mean #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrobinson
approved these changes
Mar 16, 2023
There was a problem hiding this comment.
Looks good to me, but would like a review from someone who owns this code cc @DrJosh9000 @moskyb
| @@ -239,6 +239,11 @@ Buildkite > (Org, Queue) > TotalAgentsCount | |||
|
|
|||
| When a queue is specified, only that queue's metrics are published. | |||
|
|
|||
| Jobs can be in one of the following states: | |||
| * **Scheduled**, the job hasn't been assigned to an agent yet. If you have agent capacity, this value should be close to 0. | |||
| * **Waiting**, the job is known to exist but isn't schedulable yet due to dependencies, `wait` statements, etc. This information is mostly useful to an autoscaler, since it represents work that will start soon. | |||
There was a problem hiding this comment.
This matches the PR description for when it was added #81
Co-authored-by: Patrick Robinson <[email protected]>
triarius
added a commit
that referenced
this pull request
Apr 10, 2023
\## [v5.5.5](https://github.com/buildkite/buildkite-agent-metrics/tree/v5.5.5) (2023-04-10) [Full Changelog](v5.5.4...v5.5.5) \### Changed - add notes about what the job states mean [#130](#130) (@edmund-huber) - More fixes to the automated release [#153](#153) (@triarius)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #129